batterymonitor@pdcurtis: battery percent calculation, fix for ageing batteries #7330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applet previously relied on the 'capacity' file to obtain percent charge remaning. However, with my 2012 macbook pro whose battery is not capable of reaching the design spec for full charge, this capacity is incorrect. Instead, the real effective charge percentage should be calculated using the 'charge_now' and 'charge_full' files. Matches default battery applet % charge now.
|
This should probably be an option rather than globally overriding the calculation for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applet previously relied on the 'capacity' file to obtain percent charge remaning. However, with my 2012 macbook pro whose battery is not capable of reaching the design spec for full charge, this capacity is incorrect. Instead, the real effective charge percentage should be calculated using the 'charge_now' and 'charge_full' files. Matches linux mint cinnamon default battery applet % calculation now.
@pdcurtis
Linux Mint 22.1
Cinnamon 6.4.8