Skip to content

fix: report issue button UI implementation #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Conversation

emlimlf
Copy link
Collaborator

@emlimlf emlimlf commented Aug 6, 2025

In this PR

Change the UI implementation of report issue button on the project header.

Tickets

INS-843
INS-842

@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 05:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the UI implementation of the report issue button in the project header to follow the latest design specifications. The change replaces a dropdown-based report issue option with a standalone button for better accessibility and visual prominence.

  • Converts the report issue functionality from a dropdown menu item to a dedicated button
  • Removes the ellipsis dropdown menu and associated dropdown components
  • Updates button styling with tertiary type and rounded-full class

@@ -71,6 +71,17 @@ SPDX-License-Identifier: MIT
</div>
</div>
<div class="hidden sm:flex items-center gap-4">
<lfx-button
type="tertiary"
class="!rounded-full text-nowrap"
Copy link
Preview

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using !important modifier (!rounded-full) suggests potential CSS specificity issues. Consider resolving the underlying specificity conflict instead of forcing the style with !important.

Suggested change
class="!rounded-full text-nowrap"
class="rounded-full text-nowrap"

Copilot uses AI. Check for mistakes.

>
<lfx-icon
name="comment-exclamation"
class="text-warning-600"
Copy link
Preview

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The icon color is hardcoded to text-warning-600. Consider using a CSS custom property or design token to maintain consistency with the design system and make theme changes easier.

Suggested change
class="text-warning-600"
:style="{ color: 'var(--color-warning)' }"

Copilot uses AI. Check for mistakes.

@emlimlf emlimlf merged commit b2c3143 into main Aug 7, 2025
10 checks passed
@emlimlf emlimlf deleted the fix/report-data-button branch August 7, 2025 01:15
emlimlf added a commit that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant