rping: Fix spurious failure return codes #1622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CM event thread processes events in a loop with no explicit termination. When the last CM event is received, the main thread proceeds to clean up and destroy the CM event channel. If this occurs after the CM event thread has processed the last event, but before it reaches rdma_get_cm_event again, then the subsequent call to rdma_get_cm_event will fail and cause the process to exit with a failure code even though the test was actually successful. This causes flakiness in test scripts that use rping for basic functional testing. Fix this by using an eventfd+poll to explicitly signal the CM event thread for termination. Tested by running 4096 parallel rping processes. Fixes: 6f640ff ("r7019: Introduce event channels.") Signed-off-by: Jacob Moroni <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CM event thread processes events in a loop with no explicit termination. When the last CM event is received, the main thread proceeds to clean up and destroy the CM event channel. If this occurs after the CM event thread has processed the last event, but before it reaches rdma_get_cm_event again, then the subsequent call to rdma_get_cm_event will fail and cause the process to exit with a failure code even though the test was actually successful.
This causes flakiness in test scripts that use rping for basic functional testing.
Fix this by using an eventfd+poll to explicitly signal the CM event thread for termination.
Tested by running 4096 parallel rping processes.
Fixes: 6f640ff ("r7019: Introduce event channels.")