tests: Ensure graceful resource cleaning #1618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A SEGFAULT was observed recently on some environments with python 3.12.X. To work around the issue and ensure that python garbage collector exiting gracefully, a new decorator was added that catches SkipTest unittest exceptions and closes the context and its underlying resources. An a example of a segmentation fault occurrence that this test fixes: $ python3 tests/run_tests.py test_mlx5_dma_memcpy sTraceback (most recent call last): File "cq.pyx", line 359, in pyverbs.cq.CQEX.close pyverbs.pyverbs_error.PyverbsRDMAError: Failed to destroy CQEX. Errno: 9, Bad file descriptor Exception ignored in: 'pyverbs.cq.CQEX.__dealloc__' Traceback (most recent call last): File "cq.pyx", line 359, in pyverbs.cq.CQEX.close pyverbs.pyverbs_error.PyverbsRDMAError: Failed to destroy CQEX. Errno: 9, Bad file descriptor Segmentation fault (core dumped) Signed-off-by: Edward Srouji <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A SEGFAULT was observed recently on some environments with python 3.12.X.
To work around the issue and ensure that python garbage collector exiting gracefully, a new decorator was added that catches SkipTest unittest exceptions and closes the context and its underlying resources.
An a example of a segmentation fault occurrence that this test fixes: $ python3 tests/run_tests.py test_mlx5_dma_memcpy
sTraceback (most recent call last):
File "cq.pyx", line 359, in pyverbs.cq.CQEX.close
pyverbs.pyverbs_error.PyverbsRDMAError: Failed to destroy CQEX. Errno: 9, Bad file descriptor
Exception ignored in: 'pyverbs.cq.CQEX.dealloc' Traceback (most recent call last):
File "cq.pyx", line 359, in pyverbs.cq.CQEX.close
pyverbs.pyverbs_error.PyverbsRDMAError: Failed to destroy CQEX. Errno: 9, Bad file descriptor
Segmentation fault (core dumped)