fix: [UIE-9192, UIE-9193] - DBaaS - Create and Manage Networking validation allows submitting VPC with empty subnet field and Manage Networking drawer does not reset#12889
Merged
smans-akamai merged 2 commits intolinode:developfrom Sep 17, 2025
Conversation
…dation allows submitting VPC with empty subnet field and Manage Networking drawer does not reset after opening unassign modal and reopening drawer
750f267 to
e34516f
Compare
jaalah-akamai
approved these changes
Sep 17, 2025
Contributor
jaalah-akamai
left a comment
There was a problem hiding this comment.
Reviewed this yesterday with Sam. These changes should now enforce the validation in the schema.
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/linodes/create-linode-region-select.spec.ts" |
||||||||||||||||||||
bill-akamai
approved these changes
Sep 17, 2025
Contributor
bill-akamai
left a comment
There was a problem hiding this comment.
Was able to verify steps on Staging ✅
bnussman-akamai
approved these changes
Sep 17, 2025
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This pull request fixes two issues:
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
9/23/2025
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.🔒 Use the Mask Sensitive Data setting for security.
💡 For changes requiring multiple steps to validate, prefer a video for clarity.
Validation Bug:
How to test 🧪
Prerequisites
(How to setup test environment)
databaseVpcfeature flag enabledReproduction steps
(How to reproduce the issue, if applicable)
DatabaseCreate form validation allows submitting a VPC configuration with an empty subnet field
Create Database Clusterbutton to open the Create flowCreate Database Clusterand see that the the request goes through and the cluster is created even though the subnet field is empty.private_networkproperty and contains the previously selectedsubnet_idthat was supposed to be cleared from the formDatabaseManageNetworkingDrawer form validation allows submitting a VPC configuration with an empty subnet field
Manage NetworkingbuttonSavebutton below is enabledSaveand see that the request goes throughThe Manage Networking drawer state does not reset after opening the Unassign dialog, cancelling out of it and reopening drawer.
Networkingtab and select theManage NetworkingbuttonUnassign VPCbutton in the drawer to open the Unassign dialogCancelbutton.Manage Networkingbutton again to reopen the drawerVerification steps
(How to verify changes)
DatabaseCreate form validation no longer allows submitting a VPC configuration with an empty subnet field
Create Database Clusterbutton to open the Create flowCreate Database Clusterbutton a validation error is shown for the empty Subnet field indicating that it is required and that the POST request is not made to create the new VPC.DatabaseManageNetworkingDrawer form validation no longer allows submitting a VPC configuration with an empty subnet field
Networkingtab and select theManage NetworkingbuttonSavebutton below is disabled until you select a Subnet.The Manage Networking resets state after opening the Unassign dialog, cancelling out of it, and reopening the drawer.
Manage NetworkingbuttonUnassign VPCbutton in the drawer to open the Unassign dialogCancelbutton.Manage Networkingbutton again to reopen the drawerAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅