fix: [M3-10606] - Redirects /settings to /account-settings#12841
fix: [M3-10606] - Redirects /settings to /account-settings#12841cpathipa merged 3 commits intolinode:stagingfrom
Conversation
cpathipa
requested review from
bill-akamai and
bnussman-akamai
and removed request for
a team
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts" |
|||||||||||||||||
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks Chandra! Confirmed:
/account/settingsredirects to/account-settings/settingsredirects to/account-settings
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
feature flag on:
✅ /account/settings redirects to /account-settings
✅ /settings redirects to /account-settings
feature flag off:
✅ /account-settings redirects to /account/settings
✅ /settings redirects to /account/settings
thanks @cpathipa!
(Left a comment below - if this needs to be merged quickly for the release, maybe the comment can be addressed in a follow up instead)
|
|
||
| // This supports redirecting from /settings to /account-settings(which renamed from 'settings' to 'account-settings' ). | ||
| export const settingsRouteTree = createRoute({ | ||
| getParentRoute: () => rootRoute, | ||
| path: 'settings', | ||
| beforeLoad: () => { | ||
| throw redirect({ to: '/account-settings' }); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Instead of adding this, would changing the parent route on line 14 to routeTree help?
There was a problem hiding this comment.
The line 14 block is to handle any invalid routes. This will be removed eventually as part of feature flag cleanup in the future releases.
There was a problem hiding this comment.
got it, seeing the differences with further testing - thanks Chandra!
5 participants
Description 📝
This PR redirects /settings route to /account-settings.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
9/9
Preview 📷
settings-accountsettings.mov
How to test 🧪
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅