test: [DI-27193] - Add & update tests for alert creation/edit scope changes

[agorthi-akamai]

Description 📝

Test(alerts): expand Cypress coverage for alert creation/edit (DBaaS, NodeBalancer, Firewall)

Impact
This is a significant change, as the scope touches multiple existing Cypress test cases. Reviewers should pay close attention to alert-related workflows.

Changes 🔄

This PR introduces major Cypress test updates for alert functionality. The scope includes creation and editing of both user and system alerts across the following service types:

• DBaaS
• NodeBalancer
• Firewall
• Details

Added and updated test coverage for alert creation and edit flows
Fixed failing test cases impacted by scope changes
Ensured consistency across user/system alert handling

Scope 🚢

Upon production release, changes in this PR will be visible to:

• All customers
• Some customers (e.g. in Beta or Limited Availability)
• No customers / Not applicable

Target release date 🗓️

23/09/2025

Preview 📷

create-firewall-alert.spec.ts.mp4

Uploading alert-create-validation.spec.ts.mp4…

How to test 🧪

pnpm cy:run -s 'cypress/e2e/core/cloudpulse/edit-user-alert.spec.ts,cypress/e2e/core/cloudpulse/edit-system-alert.spec.ts,cypress/e2e/core/cloudpulse/create-user-alert.spec.ts,cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts,cypress/e2e/core/cloudpulse/alert-show-details.spec.ts'

Prerequisites

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All tests and CI checks are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[mjac0bs]

Impact
This is a significant change, as the scope touches multiple existing Cypress test cases. Reviewers should pay close > attention to alert-related workflows.

@agorthi-akamai With a total diff of over 3000 lines, this PR is very large. Breaking it down into smaller scoped PRs (e.g. by product: DBaaS, Firewall, and NodeBalancer) would likely get you faster and more thorough reviews. As it is, it will take us some time.

[agorthi-akamai]

Removed two oversized Cypress spec files (create-firewall-alert.spec.ts and create-nodebalancer-alert.spec.ts) to reduce the PR size by ~1,271 lines. This will make reviews faster and more manageable.

[nikhagra-akamai]

LGTM

[mjac0bs]

I saw these pass in CI and locally, but I also saw some flake locally related to formatted time, which I'm concerned could cause failures and backups in CI if kept as is (see comment).

Will approve once that is addressed and the factories code is simplified as suggested in a comment. Most of those factories don't even look to be used in this PR, so I assume they were for test coverage that was removed to reduce scope.

[mjac0bs]

Thanks for addressing feedback - specs are passing consistently locally for me now and factories look like they're in better shape.

[linode-gh-bot]

Cloud Manager UI test results

🔺 1 failing test on test run #13 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
1 Failing	811 Passing	12 Skipped	42m 14s

Details

Failing Tests
	Spec	Test
❌	access-key.e2e.spec.ts	Cloud Manager Cypress Tests→object storage access key end-to-end tests » "before all" hook for "can create an access key with unlimited access - e2e"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"