Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12790-added-1756817237984.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Added
---

IAM RBAC: Implements IAM RBAC permissions for NodeBalancer summary tab ([#12790](https://github.com/linode/manager/pull/12790))
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { TabPanels } from 'src/components/Tabs/TabPanels';
import { Tabs } from 'src/components/Tabs/Tabs';
import { TanStackTabLinkList } from 'src/components/Tabs/TanStackTabLinkList';
import { getRestrictedResourceText } from 'src/features/Account/utils';
import { useIsResourceRestricted } from 'src/hooks/useIsResourceRestricted';
import { usePermissions } from 'src/features/IAM/hooks/usePermissions';
import { useTabs } from 'src/hooks/useTabs';
import { getErrorMap } from 'src/utilities/errorUtils';

Expand All @@ -38,11 +38,11 @@ export const NodeBalancerDetail = () => {
isLoading,
} = useNodeBalancerQuery(Number(id), Boolean(id));

const isNodeBalancerReadOnly = useIsResourceRestricted({
grantLevel: 'read_only',
grantType: 'nodebalancer',
id: nodebalancer?.id,
});
const { data: permissions } = usePermissions(
'nodebalancer',
['update_nodebalancer'],
nodebalancer?.id
);

const { handleTabChange, tabIndex, tabs } = useTabs([
{
Expand Down Expand Up @@ -90,13 +90,14 @@ export const NodeBalancerDetail = () => {
},
pathname: `/nodebalancers/${nodebalancer.label}`,
}}
disabledBreadcrumbEditButton={!permissions.update_nodebalancer}
docsLabel="Docs"
docsLink="https://techdocs.akamai.com/cloud-computing/docs/getting-started-with-nodebalancers"
spacingBottom={4}
title={nodebalancer.label}
/>
{errorMap.none && <Notice text={errorMap.none} variant="error" />}
{isNodeBalancerReadOnly && (
{!permissions.update_nodebalancer && (
<Notice
text={getRestrictedResourceText({
resourceType: 'NodeBalancers',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ const queryMocks = vi.hoisted(() => ({
.fn()
.mockReturnValue({ data: undefined }),
useParams: vi.fn().mockReturnValue({}),
userPermissions: vi.fn(() => ({
data: {
update_nodebalancer: false,
},
})),
}));

vi.mock('src/features/IAM/hooks/usePermissions', () => ({
usePermissions: queryMocks.userPermissions,
}));

vi.mock('@tanstack/react-router', async () => {
Expand Down Expand Up @@ -188,4 +197,31 @@ describe('SummaryPanel', () => {
);
});
});

it('should disable "Add a tag" if user does not have permission', () => {
const { getByText } = renderWithTheme(<SummaryPanel />, {
flags: { nodebalancerVpc: true },
});

// Tags panel
expect(getByText('Tags')).toBeVisible();
expect(getByText('Add a tag')).toBeVisible();
expect(getByText('Add a tag')).toHaveAttribute('aria-disabled', 'true');
});

it('should enable "Add a tag" if user has permission', () => {
queryMocks.userPermissions.mockReturnValue({
data: {
update_nodebalancer: true,
},
});
const { getByText } = renderWithTheme(<SummaryPanel />, {
flags: { nodebalancerVpc: true },
});

// Tags panel
expect(getByText('Tags')).toBeVisible();
expect(getByText('Add a tag')).toBeVisible();
expect(getByText('Add a tag')).not.toHaveAttribute('aria-disabled', 'true');
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import * as React from 'react';

import { Link } from 'src/components/Link';
import { TagCell } from 'src/components/TagCell/TagCell';
import { usePermissions } from 'src/features/IAM/hooks/usePermissions';
import { useKubernetesBetaEndpoint } from 'src/features/Kubernetes/kubeUtils';
import { IPAddress } from 'src/features/Linodes/LinodesLanding/IPAddress';
import { useIsResourceRestricted } from 'src/hooks/useIsResourceRestricted';
import { useKubernetesClusterQuery } from 'src/queries/kubernetes';

import { useIsNodebalancerVPCEnabled } from '../../utils';
Expand All @@ -42,11 +42,11 @@ export const SummaryPanel = () => {
);
const displayFirewallLink = !!attachedFirewallData?.data?.length;

const isNodeBalancerReadOnly = useIsResourceRestricted({
grantLevel: 'read_only',
grantType: 'nodebalancer',
id: nodebalancer?.id,
});
const { data: permissions } = usePermissions(
'nodebalancer',
['update_nodebalancer'],
nodebalancer?.id
);

const flags = useIsNodebalancerVPCEnabled();

Expand Down Expand Up @@ -265,7 +265,7 @@ export const SummaryPanel = () => {
Tags
</StyledTitle>
<TagCell
disabled={isNodeBalancerReadOnly}
disabled={!permissions.update_nodebalancer}
entity="NodeBalancer"
tags={nodebalancer?.tags}
updateTags={(tags) => updateNodeBalancer({ tags })}
Expand Down