Skip to content

hotfix: [UIE-9134] Increase page size for RBAC IAM entities call #12762

Merged
abailly-akamai merged 4 commits intolinode:stagingfrom
abailly-akamai:UIE-9134-hotfix
Aug 25, 2025
Merged

hotfix: [UIE-9134] Increase page size for RBAC IAM entities call #12762
abailly-akamai merged 4 commits intolinode:stagingfrom
abailly-akamai:UIE-9134-hotfix

Conversation

@abailly-akamai
Copy link
Copy Markdown
Contributor

@abailly-akamai abailly-akamai commented Aug 25, 2025

Description 📝

The v4beta/entities API cannot be filtered currently, and this causes some accounts with larger numbers of entities to not see some entities in the results, which are used in various UI elements like autocompletes. Increasing the page size to 500 (the max) will help delay for a real solution.
Note: the v4beta APIs do not support X-Filter at the moment, so this is just a temporary workaround.

Changes 🔄

List any change(s) relevant to the reviewer.

  • The v4beta/entities API call should now request a page size of 500.
  • In some cases, as shown below, this means that entities that were not available are now seen.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

August 26

Preview 📷

Before After
Screenshot 2025-08-21 at 10 31 59 AM Screenshot 2025-08-22 at 10 51 43 AM

How to test 🧪

Prerequisites

  • Use IAM account with role assignment permissions

Reproduction steps

  • Navigate to IAM > Roles
  • Click Assign Role next to an entity role, such as "VPC viewer" to open the assignment drawer
  • Notice that no VPCs are available to assign if the account has >> 100 (page size) entities (this may take some effort)
  • Filtering on entities does not help since the API call is not going to be made again

Verification steps

  • Navigate to IAM > Roles
  • Click Assign Role next to an entity role, such as "VPC viewer" to open the assignment drawer
  • Notice that now some VPCs are available to assign if the account has < 500 (page size) total entities
  • Filtering on entities still does nothing - the only change was the page size
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai marked this pull request as ready for review August 25, 2025 14:03
@abailly-akamai abailly-akamai requested a review from a team as a code owner August 25, 2025 14:03
@abailly-akamai abailly-akamai requested review from bill-akamai, hasyed-akamai and mjac0bs and removed request for a team August 25, 2025 14:03
bill-akamai
bill-akamai previously approved these changes Aug 25, 2025
Copy link
Copy Markdown
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verifying changes ✅

@jdamore-linode
Copy link
Copy Markdown
Contributor

Just confirming the test failure isn't related to this PR's changes (see also M3-10514)

mjac0bs
mjac0bs previously approved these changes Aug 25, 2025
Copy link
Copy Markdown
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thank you!

Screenshot 2025-08-25 at 9 13 44 AM

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 25, 2025
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Aug 25, 2025
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is going to staging, we don't need this changeset. @bill-akamai Do you want to update the changelog directly?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we keep them? They seem relevant staging or not? (sorry i don't remember what the best course is for staging fixes)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changesets have already been deleted and translated to changelogs at this stage in the release process. Agreed that this change is relevant to document! Best course is just to update the changelog, but if we don't want to dismiss reviews on this PR, that can also be done on the staging branch directly.

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @alioso - can you update the changelog directly rather than adding the changeset(s)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! of course i'll do that

@abailly-akamai abailly-akamai dismissed stale reviews from mjac0bs and bill-akamai via 462b196 August 25, 2025 17:08
Copy link
Copy Markdown
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abailly-akamai !

@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing734 Passing4 Skipped123m 13s

Details

Failing Tests
SpecTest
object-storage-objects-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster objects » can upload, access, and delete objects

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts"

@abailly-akamai abailly-akamai merged commit 7079401 into linode:staging Aug 25, 2025
39 of 42 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants