Skip to content

tests [M3-10513] Fix for flakey test in alerts-listing-page.spec.ts #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmcintyr-akamai merged 12 commits into from
Sep 3, 2025
Merged

tests [M3-10513] Fix for flakey test in alerts-listing-page.spec.ts #12736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ad2a49d
limit cypress scope to fix test
dmcintyr-akamai Aug 20, 2025
494c643
Added changeset: Fix for flakey test in alerts-listing-page.spec.ts
dmcintyr-akamai Aug 20, 2025
76504a6
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 20, 2025
0671427
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 20, 2025
e35c585
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 21, 2025
cfd7d89
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 22, 2025
f7d4bc8
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 25, 2025
76a58c2
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 27, 2025
63822e3
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 28, 2025
710db46
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Aug 28, 2025
fd676f5
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Sep 2, 2025
ebaf670
Merge branch 'develop' into M3-10513_flakey-alert-listing
dmcintyr-akamai Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12736-tests-1755708307206.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tests
---

Fix for flakey test in alerts-listing-page.spec.ts ([#12736](https://github.com/linode/manager/pull/12736))
31 changes: 17 additions & 14 deletions packages/manager/cypress/e2e/core/cloudpulse/alerts-listing-page.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,24 +260,27 @@
});

it('should validate UI elements and alert details', () => {
// Validate navigation links and buttons
cy.findByText('Alerts').should('be.visible');
// filter to main content area to avoid confusion w/ 'Alerts' nav link in left sidebar
cy.get('main').within(() => {
// Validate breadcrumb and buttons
cy.findByText('Alerts', { exact: false }).should('be.visible');

cy.findByText('Definitions')
.should('be.visible')
.and('have.attr', 'href', alertDefinitionsUrl);
ui.buttonGroup.findButtonByTitle('Create Alert').should('be.visible');
cy.findByText('Definitions')
.should('be.visible')
.and('have.attr', 'href', alertDefinitionsUrl);
ui.buttonGroup.findButtonByTitle('Create Alert').should('be.visible');

Check warning on line 271 in packages/manager/cypress/e2e/core/cloudpulse/alerts-listing-page.spec.ts

View workflow job for this annotation

GitHub Actions / ESLint Review (manager) 

[eslint] reported by reviewdog 🐶
Define a constant instead of duplicating this literal 7 times.

Raw Output:
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 7 times.","line":271,"column":40,"nodeType":"Literal","endLine":271,"endColumn":54}

// Validate table headers
cy.get('[data-qa="alert-table"]').within(() => {
expectedHeaders.forEach((header) => {
cy.findByText(header).should('have.text', header);
// Validate table headers
cy.get('[data-qa="alert-table"]').within(() => {
expectedHeaders.forEach((header) => {

Check warning on line 275 in packages/manager/cypress/e2e/core/cloudpulse/alerts-listing-page.spec.ts

View workflow job for this annotation

GitHub Actions / ESLint Review (manager) 

[eslint] reported by reviewdog 🐶
Refactor this code to not nest functions more than 4 levels deep.

Raw Output:
{"ruleId":"sonarjs/no-nested-functions","severity":1,"message":"Refactor this code to not nest functions more than 4 levels deep.","line":275,"column":42,"nodeType":null,"endLine":275,"endColumn":44}
cy.findByText(header).should('have.text', header);
});
});
});

// Validate alert details
mockAlerts.forEach((alert) => {
validateAlertDetails(alert);
// Validate alert details
mockAlerts.forEach((alert) => {
validateAlertDetails(alert);
});
});
});

Expand Down