fix: [M3-10394] - Use human readable date/time for maintenance window#12605
Merged
jaalah-akamai merged 4 commits intolinode:developfrom Jul 30, 2025
Merged
fix: [M3-10394] - Use human readable date/time for maintenance window#12605jaalah-akamai merged 4 commits intolinode:developfrom
jaalah-akamai merged 4 commits intolinode:developfrom
Conversation
jaalah-akamai
requested review from
bill-akamai and
dwiley-akamai
and removed request for
a team
bill-akamai
reviewed
Jul 30, 2025
| @@ -12,7 +14,13 @@ export const LinodeMaintenanceText = ({ | |||
| return ( | |||
| <> | |||
| This Linode’s maintenance window {isOpened ? 'opened' : 'opens'} at{' '} | |||
Contributor
There was a problem hiding this comment.
I think this could lead to awkward phrasing like "This Linode's maintenance window opened at 2 hours ago".
Perhaps we could add a conditional check on whether or not the time is relative to display the "at" string.
Contributor
Author
There was a problem hiding this comment.
I removed the humanizeCuttoff option so this shouldn't happen - good catch
bill-akamai
approved these changes
Jul 30, 2025
dwiley-akamai
approved these changes
Jul 30, 2025
Collaborator
Cloud Manager UI test results🎉 701 passing tests on test run #4 ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR improves the user experience by converting the maintenance window date/time display in the
LinodeMaintenanceTextcomponent from a database format to a more readable format. Instead of showing dates like "2024-01-15T14:30", the component now displays "2024-01-15 14:30"Changes 🔄
Tbeing in stringTarget release date 🗓️
N/A
Preview 📷
Note
Focus on the format, not the times in the screenshots
How to test 🧪
Verification steps
Alternative
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅