Skip to content

upcoming: [M3-9113] - Add Interface History table#12321

Merged
bnussman-akamai merged 31 commits intolinode:developfrom
coliu-akamai:m3-9113-2
Sep 17, 2025
Merged

upcoming: [M3-9113] - Add Interface History table#12321
bnussman-akamai merged 31 commits intolinode:developfrom
coliu-akamai:m3-9113-2

Conversation

@coliu-akamai
Copy link
Copy Markdown
Contributor

@coliu-akamai coliu-akamai commented Jun 3, 2025

Note

Update 8/13 - likely to merge in september after discussing with API team about stuff

Description 📝

Adds the interface history dialog/table. Some background info: earlier in the year, the API team put this endpoint on hold for further reevaluation. They've since brought it back (see internal ticket comments for API's PRs), so we're adding this table back as well.

Changes 🔄

  • Add dialog and table
  • Add react query / tests
  • Add mock data

Target release date 🗓️

depending on API's releasing of this endpoint, keeping an eye out

Preview 📷

button dialog + table
image image

How to test 🧪

Prerequisites

For now, use MSW crud and create a Linode using new interfaces
(once the API pr gets merged, we'll be able to test with live data via devenv)

Verification steps

  • confirm history table dialog opens
  • confirm it matches the screenshot in the ticket
    • to test pagination, change the number of history objects returned in handlers/linodes.ts
  • confirm tests pass
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai marked this pull request as ready for review June 3, 2025 20:32
@coliu-akamai coliu-akamai requested a review from a team as a code owner June 3, 2025 20:32
@coliu-akamai coliu-akamai requested review from abailly-akamai, bnussman-akamai and jaalah-akamai and removed request for a team June 3, 2025 20:32
Copy link
Copy Markdown
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great a code is clean!

Couple things that could use improvements:
Screenshot 2025-06-04 at 15 31 10
Do we really want a full height modal? it looks a bit odd and since I assume the table will be paginated we may not need the full height by default?

Filtering:
when filtering you end up with networking?order=desc&orderBy=version - i think you want to be more granular in your URL since networking is your parent page

I seem to see some pretty aggressive re-renders in the modal when sorting, not sure if that can be improved

lastly, i think you want to clear your search params when closing the dialog

Copy link
Copy Markdown
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and feature look great!

Let a few small things of feedback

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jun 5, 2025
@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Jun 5, 2025
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 10, 2025
@bnussman-akamai
Copy link
Copy Markdown
Member

I feature flagged the Interface History table so we can go ahead and merge it to keep it from going stale.

The feature works in lower environments, we just need to toggle the flag once this is available in production.

Screenshot 2025-09-16 at 11 37 11 AM

@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🎉 809 passing tests on test run #28 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing809 Passing9 Skipped44m 45s

@bnussman-akamai bnussman-akamai merged commit 7ce5a12 into linode:develop Sep 17, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Linode Interfaces

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants