upcoming: [M3-9113] - Add Interface History table#12321
upcoming: [M3-9113] - Add Interface History table#12321bnussman-akamai merged 31 commits intolinode:developfrom
Conversation
abailly-akamai
left a comment
There was a problem hiding this comment.
Looks great a code is clean!
Couple things that could use improvements:

Do we really want a full height modal? it looks a bit odd and since I assume the table will be paginated we may not need the full height by default?
Filtering:
when filtering you end up with networking?order=desc&orderBy=version - i think you want to be more granular in your URL since networking is your parent page
I seem to see some pretty aggressive re-renders in the modal when sorting, not sure if that can be improved
lastly, i think you want to clear your search params when closing the dialog
bnussman-akamai
left a comment
There was a problem hiding this comment.
Code and feature look great!
Let a few small things of feedback
...des/LinodesDetail/LinodeNetworking/LinodeInterfaces/LinodeInterfacesHistory/HistoryTable.tsx
Outdated
Show resolved
Hide resolved
...des/LinodesDetail/LinodeNetworking/LinodeInterfaces/LinodeInterfacesHistory/HistoryTable.tsx
Outdated
Show resolved
Hide resolved
...odesDetail/LinodeNetworking/LinodeInterfaces/LinodeInterfacesHistory/HistoryTableContent.tsx
Outdated
Show resolved
Hide resolved
...es/LinodesDetail/LinodeNetworking/LinodeInterfaces/LinodeInterfacesHistory/HistoryDialog.tsx
Show resolved
Hide resolved
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
Cloud Manager UI test results🎉 809 passing tests on test run #28 ↗︎
|


Note
Update 8/13 - likely to merge in september after discussing with API team about stuff
Description 📝
Adds the interface history dialog/table. Some background info: earlier in the year, the API team put this endpoint on hold for further reevaluation. They've since brought it back (see internal ticket comments for API's PRs), so we're adding this table back as well.
Changes 🔄
Target release date 🗓️
depending on API's releasing of this endpoint, keeping an eye out
Preview 📷
How to test 🧪
Prerequisites
For now, use MSW crud and create a Linode using new interfaces
(once the API pr gets merged, we'll be able to test with live data via devenv)
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅