upcoming: [M3-9706] - Fix Subnets Table for Linodes using new interfaces

[coliu-akamai]

Description 📝

• Fixes SubnetLinodeRow logic so that Linodes using new interfaces show up correctly in the table

Changes 🔄

• send requests to Linode Interface endpoints if Linode is using new interfaces
• since interface Data now gives us the configID, we can directly query for the relevant config profile interface. However, we still need to get a config to check for unrecommended configurations, so I've updated to query for a single config rather than all configs
• Add test to confirm Linode Interface info shows up correctly

Target release date 🗓️

4/22

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before	After

How to test 🧪

• using Prod API and have the customer tag (reach out for tag) on your prod admin account
• Enable the Linode Interfaces feature flag using our local dev tools
• have a Linode using new interfaces assigned to a VPC

Verification steps

• Confirm VPC IP, ranges, and firewall show up as expected
• confirm link to Linode navigates to interface details page

Logic for config profile interfaces

• confirm things still work as expected
  • reboot chip shows up as expected * (I believe these changes should make the reboot chip friendlier for linodes with multiple configs - ie it won't show up when it's not supposed to)
  • unrecomended config notice shows up as expected *
  • everything else still works as expected

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All unit tests are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[coliu-akamai]

we are now given the config id in SubnetLinodeInterfaceData, so we'll no longer have to fetch all configs to find the interface attached to this subnet. I'm still fetching the single config the interface belongs to, due to hasUnrecommendedConfiguration (for implicit primary interfaces)

[coliu-akamai]

not sure how many Linodes have multiple configs, but I remember that the reboot chip is especially finnicky for that case. This clears up the logic a bit - now the only interface we care about is the one we're displaying.

Previously, the reboot chip would display even after we'd already rebooted our Linode with config A if some other config B had an inactive VPC interface.

This reboot chip is not needed for Linode Interfaces - we can only apply networking interface changes when the Linode is shutdown. Upon turning back on and booting, those changes get applied, so no reboot needed (if my understanding of the API spec's overview is correct)

[coliu-akamai]

@dwiley-akamai @hana-akamai also requesting you since this touches a lot of old VPC logic and would appreciate the extra eyes!

[dwiley-akamai]

VPC IP, ranges, and firewall show up as expected ✅

Linode assigned to VPC

• w/ legacy config/interfaces: links to linode details page ✅
• w/ linode interfaces: links to linode details > Network tab > Interface Details drawer ✅

Config interfaces

• Reboot indicator behavior ✅
• Unrecommended Configuration notice ✅

[hana-akamai]

Functionality is looking good!

[cpathipa]

Nice work @coliu-akamai confirming on the verification steps.

[bnussman-akamai]

Nice, thanks for fixing up this flow 🙏

Table looks good for both legacy and new interfaces

[linode-gh-bot]

Cloud Manager UI test results

🎉 540 passing tests on test run #27 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
0 Failing	540 Passing	4 Skipped	99m 18s