Add label field to lkenodepool #786
Open
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphan-akamai
requested review from
PawelSnoch and
yec-akamai
and removed request for
a team
| @@ -92,6 +93,7 @@ type LKENodePoolCreateOptions struct { | |||
| Tags []string `json:"tags"` | |||
| Labels LKENodePoolLabels `json:"labels"` | |||
| Taints []LKENodePoolTaint `json:"taints"` | |||
| Label string `json:"label,omitempty"` | |||
There was a problem hiding this comment.
Can we make it as a pointer to distinguish "" and field omitted in actual API call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
This PR adds the
Labelfield to lkenodepool. LKE recently added support for lkenodepool naming via theLabelfield. (ex., when a customer provides aLabelduring the creation/update of a lkenodepool, nodes in that nodepool will following this naming convention<lkenodepool namespace>-<lkenodepool label>-<5 char hash>).✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
Unit Tests
Run
make test-unit TEST_ARGS='-run TestLKENodePool_Create'Run
make test-unit TEST_ARGS='-run TestLKENodePool_Update'📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.