fix(cli): improved support for native sidecar servers in linkerd check --proxy
#14779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck --proxy` (Extracted from #14566) The "opaque ports are properly annotated" check had a bug where it only validated regular containers, missing ports in init containers (native sidecars). This meant mismatched annotations between pods and services could go undetected when the port belonged to an init container. When a service had the opaque-ports annotation but the corresponding pod did not, the check would incorrectly pass if the port was defined in an init container instead of a regular container. This commit extends the check to validate ports in both regular containers and init containers, ensuring consistent opaque-ports annotations across pods and services regardless of where the port is defined.
adleong
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Extracted from #14566)
The "opaque ports are properly annotated" check had a bug where it only validated regular containers, missing ports in init containers (native sidecars). This meant mismatched annotations between pods and services could go undetected when the port belonged to an init container.
When a service had the opaque-ports annotation but the corresponding pod did not, the check would incorrectly pass if the port was defined in an init container instead of a regular container.
This commit extends the check to validate ports in both regular containers and init containers, ensuring consistent opaque-ports annotations across pods and services regardless of where the port is defined.