fix(helm): Fix helm rendering error when upgrading #14244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14228
When upgrading from a previous version of Linkerd, the
proxy.tracingkey will not exist in the Linkerd config ConfigMap. If a user attempts to use the inject CLI command in--manualmode, the config will be loaded from the Linkerd config ConfigMap and then rendering of the pod patch template will fail:This is because the template is attempting to access the
enabledkey in the tracing struct which is nil.We add guards using the
digHelm template function so that template rendering does not fail, even if theproxy.tracingkey is not present.