Skip to content

Conversation

@adleong
Copy link
Member

@adleong adleong commented Jul 14, 2025

Fixes #14228

When upgrading from a previous version of Linkerd, the proxy.tracing key will not exist in the Linkerd config ConfigMap. If a user attempts to use the inject CLI command in --manual mode, the config will be loaded from the Linkerd config ConfigMap and then rendering of the pod patch template will fail:

template: patch/templates/patch.json:106:16: executing "patch/templates/patch.json" at <.Values.proxy.tracing.enable>: nil pointer evaluating interface {}.enable

This is because the template is attempting to access the enabled key in the tracing struct which is nil.

We add guards using the dig Helm template function so that template rendering does not fail, even if the proxy.tracing key is not present.

@adleong adleong requested a review from a team as a code owner July 14, 2025 22:33
@adleong adleong merged commit 53b0232 into main Jul 15, 2025
66 of 68 checks passed
@adleong adleong deleted the alex/patch-dig branch July 15, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manual injection broken

3 participants