feat(helm): grant linkerd-config read access to additional SAs #14092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of this change is to enable extensions to access Linkerd's configuration. It introduces the linkerd-config RoleBinding, associated to the existing Role `ext-namespace-metadata-linkerd-config` that grants read access to the linkerd-config ConfigMap (that Role name is now outdated but leaving as-is to avoid disruption). The service accounts for that binding are to be listed on the new `values.yaml` entry `configAccess`, for example: ```yaml configAccess: - name: ext1 namespace: linkerd-ext1 - name: ext2 namespace: linkerd-ext2 ```
alpeb
force-pushed
the
alpeb/linkerd-config-rb
branch
from
06fe4e4 to
1b57ee4
Compare
This reverts commit 1b57ee4.
adleong
reviewed
Jun 3, 2025
olix0r
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this change is to enable extensions to access Linkerd's configuration.
It introduces the linkerd-config RoleBinding, associated to the existing Role
ext-namespace-metadata-linkerd-configthat grants read access to the linkerd-config ConfigMap (that Role name is now outdated but leaving as-is to avoid disruption).The service accounts for that binding are to be listed on the new
values.yamlentryconfigReaders, for example: