fix(multicluster): affinities for controllers #14028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #14008 In the linkerd-multicluster chart (or via `linkerd mc install|upgrade`), setting `enablePodAntiAffinity: true` for specific multicluster controllers or globally was causing the following error: ``` Error: template: linkerd-multicluster/templates/controller/pdb.yaml:12:7: executing "linkerd-multicluster/templates/controller/pdb.yaml" at <include "partials.annotations.created-by" .>: error calling include: template: linkerd-multicluster/charts/partials/templates/_metadata.tpl:2:33: executing "partials.annotations.created-by" at <.Values.cliVersion>: nil pointer evaluating interface {}.cliVersion ``` The problem was with the PodDisruptionBudget manifest not passing the proper context to the `annotations.created-by` partials. Also, the `nodeAffinity` setting wasn't being taken into account for such controllers. The output can be tested with `bin/linkerd mc install -f values.yaml`, using this as `values.yaml` (put something that makes sense for nodeAffinity, if you want to apply this to the cluster): ```yaml controllers: - link: ref: name: target1 enablePodAntiAffinity: true nodeAffinity: foo: bar ``` Note: Also added `multicluster/charts/**` to the changed-files actions list, for the multicluster tests to be triggered whenever a multicluster manifest changes.
alpeb
force-pushed
the
alpeb/fix-mc-enablepodantiaffinity
branch
from
4f52556 to
50c9960
Compare
adleong
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14008
In the linkerd-multicluster chart (or via
linkerd mc install|upgrade), settingenablePodAntiAffinity: truefor specific multicluster controllers or globally was causing the following error:The problem was with the PodDisruptionBudget manifest not passing the proper context to the
annotations.created-bypartials.Also, the
nodeAffinitysetting wasn't being taken into account for such controllers.The output can be tested with
bin/linkerd mc install -f values.yaml, using this asvalues.yaml(put something that makes sense for nodeAffinity, if you want to apply this to the cluster):