fix(policy): include TCPRoute policy on opaque appProtocol services#13948
Merged
fix(policy): include TCPRoute policy on opaque appProtocol services#13948
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
sfleen
reviewed
Apr 21, 2025
cratelyn
reviewed
Apr 21, 2025
sfleen
approved these changes
Apr 21, 2025
adleong
changed the title
olix0r
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Service has a port marked with
appProtocol: linkerd.io/opaque, the policy controller returns only the default opaque route and any TCPRoutes attached to that service and port are ignored.We include any TCPRoute in the outbound policy when the
appProtocolis marked as opaque.Furthermore, we update the logic to treat any unknown value for
appProtocolas opaque (when previously, an unknown value was ignored, allowing any route type to be attached). The consequence of this is TCPRoute is the only route type that can be attached to a pork with an unknown value forappProtocol.Yet furthermore, we updated the logic to allow GRPCRoutes to be attached to ports marked with
appProtocol: kubernetes.io/h2c. This means that either GRPCRoutes or HTTPRoutes may be attached to such ports and the more specific type (GRPCRoute) will take higher precedence.