Skip to content

Conversation

@adleong
Copy link
Member

@adleong adleong commented Apr 8, 2025

When running linkerd install --crds on a cluster without the Gateway API installed, Linkerd will return an error prompting the user to install the Gateway API first. However, Linkerd will also print the linkerd install command usage along with the error message. This is confusing because the usage includes example commands which are not relevant to the error and can mislead the user about what action they need to take.

We print only the error message in this case and not the usage help.

@adleong adleong requested a review from a team as a code owner April 8, 2025 22:03
Copy link
Member

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you for fixing this @adleong 🙂

@alpeb alpeb merged commit a1d7ff1 into main Apr 9, 2025
40 checks passed
@alpeb alpeb deleted the alex/cl-error-ify branch April 9, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants