fix(multicluster): correct Helm manifest whitespacing #13815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller This fixes a bug recently introduced by #13770, where installing the multicluster extension with more than one controller would result in invalid yaml: ``` $ bin/helm-build $ helm template linkerd-multicluster multicluster/charts/linkerd-multicluster \ --set controllers[0].link.ref.name=target1 --set controllers[1].link.ref.name=target2 | \ sed -n '27,32p' subjects: - kind: ServiceAccount name: controller-target1 namespace: default--- kind: ServiceAccount apiVersion: v1 ``` The fix consists on properly tunning the whitespace handling in the rbac.yaml template.
Member
|
nit: subject be a 'fix', e.g.: |
alpeb
changed the title
alpeb
changed the title
adleong
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug recently introduced by #13770, where installing the multicluster extension with more than one controller would result in invalid yaml:
The fix consists on properly tunning the whitespace handling in the rbac.yaml template.