feat(mutlicluster): Add support for excluding labels and annotations from federated and mirror services #13802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
…equeues Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Member
Author
|
pay no attention to my unhinged commit history |
Member
|
I'm gonna be squashing all the commits together to facilitate resolving conflicts with main. Edit: I was trying to rebase, but it's actually easier to just merge main. |
alpeb
added a commit
that referenced
this pull request
Mar 26, 2025
alpeb
added a commit
to linkerd/website
that referenced
this pull request
Mar 27, 2025
This accounts for the work from linkerd/linkerd2#13783 and linkerd/linkerd2#13802 where we defined the criteria for copying metadata (labels, annotations and ports) from mirrored services into federated services.
alpeb
added a commit
to linkerd/website
that referenced
this pull request
Apr 11, 2025
* Add "Metadata Coyping" section to the multicluster ref doc This accounts for the work from linkerd/linkerd2#13783 and linkerd/linkerd2#13802 where we defined the criteria for copying metadata (labels, annotations and ports) from mirrored services into federated services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #13801
Adds support for excluding certain labels and annotations from being copied onto mirror and federated services. This makes use of the
excludedLabelsandexcludedAnnoationsfields in the Link resource. These fields take a list of strings which may be literal label/annotation names or they may be group globs of the form<group>/*which will match all labels/annotations beginning with<group>/. Any matching labels or annotations will not be copied.We also add corresponding flags to the
mc linkcommand:--excluded-labelsand--excluded-annotationsfor setting these fields on the Link resource.