feat(multicluster): have linkerd-multicluster chart be responsible for service mirror controllers - tests #13800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
alpeb
force-pushed
the
alpeb/multicluster-chart-manage-smc-tests
branch
2 times, most recently
from
1ee611f to
d88ceac
Compare
adleong
approved these changes
Mar 15, 2025
| cases: | ||
| - {k8s: "v1.23", manage-controllers: false} | ||
| - {k8s: "v1.32", manage-controllers: false} | ||
| - {k8s: "v1.32", manage-controllers: true} |
Member
There was a problem hiding this comment.
How much time does adding a third case here add to our CI runs?
Member
Author
There was a problem hiding this comment.
None, these cases run in parallel. We could start experiencing resource contention the more parallel jobs we add, but I don't think I've seen that in this repo.
Member
There was a problem hiding this comment.
We definitely see that when there are many concurrent jobs (dependabot, releases) running. It may be tolerable but it's another thing that will need retries/etc, so we shouldn't assume it's free.
alpeb
force-pushed
the
alpeb/multicluster-chart-manage-smc-cli-install
branch
from
052ddd5 to
b6f7911
Compare
Base automatically changed from
alpeb/multicluster-chart-manage-smc-cli-install
to
main
March 17, 2025 17:16
…r service mirror controllers - tests Followup to #13770, #13781 and #13782, based off of branch alpeb/multicluster-chart-manage-smc-cli-install Addresses test task in #13768 This introduces a new boolean flag `multicluster-target-context` to the multicluster tests, that when set to true: - the multicluster extension is installed in both clusters passing a config for a `controllers` entry. - the `linkerd mc link` command is run with `--service-mirror=false` so it only outputs the Link CR and the credentials secrets. This is used in a new test triggered in parallel in the test-multicluster integration test job.
alpeb
force-pushed
the
alpeb/multicluster-chart-manage-smc-tests
branch
from
d88ceac to
133c5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #13770, #13781 and #13782, based off of branch alpeb/multicluster-chart-manage-smc-cli-install
Addresses test task in #13768
This introduces a new boolean flag
multicluster-target-contextto the multicluster tests, that when set to true:controllersentry.linkerd mc linkcommand is run with--service-mirror=falseso it only outputs the Link CR and the credentials secrets.This is used in a new test triggered in parallel in the test-multicluster integration test job.