feat(policy): Add opaque protocol configuration #13660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
force-pushed
the
protocol-detect-opaque
branch
3 times, most recently
from
6f03752 to
0271513
Compare
sfleen
changed the title
sfleen
force-pushed
the
protocol-detect-opaque
branch
2 times, most recently
from
1c010c0 to
7df91c4
Compare
sfleen
force-pushed
the
protocol-detect-opaque
branch
5 times, most recently
from
2cc71b9 to
698a827
Compare
adleong
reviewed
Feb 21, 2025
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Is the plan to support this in the GetProfiles codepath in the destination controller as well? Or are we deciding that ServiceProfiles are incompatible with being able to specify appProtocol?
Contributor
Author
|
Yep, that's on the roadmap for one of the later milestones. Doing it this way for now lets us make this change entirely in the policy controller while giving the proxy behavior we need in the short term. |
adleong
approved these changes
Feb 24, 2025
This allows specifying that a service port is opaque via `"linkerd.io/opaque"` in the `appProtocol` field. This also includes a fair amount of tests and test infrastructure for future `appProtocol` values. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
protocol-detect-opaque
branch
from
698a827 to
6f5afad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying that a service port is opaque via "linkerd.io/opaque" in the appProtocol field.
This also includes a fair amount of tests and test infrastructure for future appProtocol values.