feat(proto-detect): Convert opaque ports to app protocol #13659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
force-pushed
the
protocol-detect-2
branch
from
5f8a57e to
59c293d
Compare
sfleen
force-pushed
the
protocol-detect-2
branch
2 times, most recently
from
e23fd8b to
b412a89
Compare
olix0r
reviewed
Feb 14, 2025
Member
olix0r
left a comment
olix0r
left a comment
There was a problem hiding this comment.
This is looking pretty good! A few small things:
olix0r
reviewed
Feb 14, 2025
sfleen
force-pushed
the
protocol-detect-2
branch
2 times, most recently
from
32afa9d to
3ebe410
Compare
Member
|
This looks good to me. I'd like @adleong to take a look before merging so we're in sync as the followup PRs come into view. |
Member
|
When merging, the subject should probably be feat(policy): ... for consistency. |
adleong
approved these changes
Feb 17, 2025
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Food for thought, feel free to ignore:
Is it redundant that we store and Option and AppProtocol has an Unknown variant? Is there a semantic difference between None and Some(Unknown)?
Contributor
Author
|
There is a difference, |
Currently, we store whether or not a port in a parent is opaque with a simple boolean. This works, but is somewhat restrictive if we want to specifiy different port protocols in the resource definition. This converts it to a proper `AppProtocol` enum, which will allow us to use different protocol specifications for ports in the future. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
protocol-detect-2
branch
from
3ebe410 to
9b4a271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we store whether or not a port in a parent is opaque with a simple boolean. This works, but is somewhat restrictive if we want to specifiy different port protocols in the resource definition.
This converts it to a proper
AppProtocolenum, which will allow us to use different protocol specifications for ports in the future.