refactor(policy): Use gateway API bindings from the official gateway-api crate #13643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Feb 11, 2025
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
In preparation for updating kubert to use a newer Lease API (supporting diagnostics), this change extracts the lease initialization logic into a dedicated module so that the new interface may be established (roughly) before the details change.
kubert v0.23.0 includes updates to several core dependencies, including: * http v1 * hyper v1 * kube v0.98 * prometheus-client v0.23 * tonic v0.12 * tower v0.5 This change updates the policy controller to use these new versions. The k8s-gateway-api dependency is temporarily pinned to a git repository in anticipation of adopting an alternate crate backend.
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
adleong
changed the title
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Feb 26, 2025
policy-controller/runtime/Cargo.toml
Outdated
| "clap", | ||
| "index", | ||
| "lease", | ||
| "runtime-diagnostics", |
Member
There was a problem hiding this comment.
let's do this in a followup
Suggested change
| "runtime-diagnostics", |
olix0r
reviewed
Feb 26, 2025
Member
olix0r
left a comment
olix0r
left a comment
There was a problem hiding this comment.
I think we also probably want to update the dependabot.yaml to group this dep with our other kube deps.
Signed-off-by: Alex Leong <[email protected]>
olix0r
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes our dependency on the hand-rolled kubernetes gateway API bindings from the
k8s-gateway-apicrate and replaces them with the official generated bindings from thegateway-apicrate.