fix(policy): Update outbound policy routes even when parent ref has no port #13584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
…tale Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parent_refof an xRoute resource can optionally specify a port. If no port is specified, the route applies to all ports. These routes withparent_refwhich do not specify a port are stored differently than routes which do, since these routes need to be applied for to all watches on any port on the parent. When services are updated/created, we perform a reindex to ensure that all routes have the correct information about their backends. However, routes which are stored in the separate way were not being updated in this case. This means that routes with aparent_refwith no port can, depending on the sequence of operations, have stale information about their backend services.We update these routes during the reindex operation to ensure they have up to date information about their backends and add a test for this behavior.