Skip to content

Conversation

@alpeb
Copy link
Member

@alpeb alpeb commented Nov 14, 2024

This introduces a new end-to-end test excercising rate-limiting for:

  1. a client with a meshed identity reaching the limit per identity
  2. a client with a singled-out meshed identity reaching an override limit
  3. an unmeshed client reaching the limit per identity
  4. a client with a meshed identity reaching the total limit

The first three cases are tested simultaneously, the forth one is tested separately.

This introduces a new end-to-end test excercising rate-limiting for:

1) a client with a meshed identity reaching the limit per identity
2) a client with a singled-out meshed identity reaching an override limit
3) an unmeshed client reaching the limit per identity
4) a client with a meshed identity reaching the total limit

The first three cases are tested simultaneously, the forth one is tested
separately.
@alpeb alpeb requested a review from a team as a code owner November 14, 2024 20:45
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool

@alpeb alpeb merged commit 20cd9a2 into main Nov 16, 2024
44 checks passed
@alpeb alpeb deleted the alpeb/ratelimit-int-test branch November 16, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants