Skip to content

Conversation

@zaharidichev
Copy link
Member

In a previous PR (#13246) we introduced an egress networks namespace that is used to create EgressNetwork objects that affect all client workloads.

This change makes this namespace configurable through helm values. Additionally, we unify the naming convention of the arguments to use egress as opposed to external

Signed-off-by: Zahari Dichev [email protected]

@zaharidichev zaharidichev requested a review from a team as a code owner October 31, 2024 09:01
@zaharidichev zaharidichev requested a review from adleong October 31, 2024 09:01
Signed-off-by: Zahari Dichev <[email protected]>
# Egress related configuration
egress:
# -- The namespace that is used to store egress configuration that affects all client workloads in the cluster
globalEgressNetworkNamespace: linkerd-egress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline at the end of file

Signed-off-by: Zahari Dichev <[email protected]>
@zaharidichev zaharidichev merged commit 4b10157 into main Nov 1, 2024
47 checks passed
@zaharidichev zaharidichev deleted the zd/make-egress-ns-configurable branch November 1, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants