-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add HTTPLocalRateLimitPolicy support #13231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b82277b to
1d84d49
Compare
b65187d to
b7f983b
Compare
dcd1ff9 to
aff1aab
Compare
aff1aab to
29eb8ed
Compare
olix0r
reviewed
Nov 1, 2024
charts/linkerd-crds/templates/policy/http-local-ratelimit-policy.yaml
Outdated
Show resolved
Hide resolved
29eb8ed to
05834be
Compare
05834be to
c10f9a8
Compare
alpeb
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Nov 6, 2024
Implemented inbound http local rate limiting, through the [governor crate](https://github.com/boinkor-net/governor), which uses the Generic Cell Rate algorithm. Ref linkerd/linkerd2#13231 for the policy-controller support. --------- Co-authored-by: Oliver Gould <[email protected]>
olix0r
reviewed
Nov 8, 2024
olix0r
reviewed
Nov 8, 2024
c10f9a8 to
b000104
Compare
olix0r
approved these changes
Nov 8, 2024
8538d46 to
ed36e3a
Compare
ed36e3a to
2c9c25b
Compare
alpeb
added a commit
that referenced
this pull request
Nov 12, 2024
* HTTPLocalRateLimitPolicy validator Followup to #13231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the HTTPLocalRateLimitPolicy CRD, which is indexed by the policy controller and exposed by the inbound API.
Testing
In a cluster with linkerd and emojivoto injected, deploy these resources:
Then see how the RL policy is exposed at the inbound API under the protocol section, with
linkerd dg policy -n emojivoto po/web-85f6fb8564-jp67d 8080: