Update generated client-go code #13167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
alpeb
approved these changes
Oct 18, 2024
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Looks good to me 👍
The crds list in update-codegen.sh still points to server:v1beta1 instead of the latest server:v1beta3, but it appears that loop doesn't make any difference and maybe could be removed? 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our generated client-go code committed in the repo has diverged from the code generated by the codegen tools.
We bring them back in sync by running
bin/updated-codegen.sh. This should be a non-functional and non-breaking change.