Skip to content

Conversation

@sfleen
Copy link
Collaborator

@sfleen sfleen commented Feb 11, 2025

A previous change enabling OpenTelmetry forgot to include attributes from the span itself, in addition to the request level spans as we do in the old OpenCensus exporter. This adds those attributes back in.

A previous change enabling OpenTelmetry forgot to include attributes from the span itself, in addition to the request level spans as we do in the old OpenCensus exporter. This adds those attributes back in.

Signed-off-by: Scott Fleener <[email protected]>
@sfleen sfleen requested a review from a team as a code owner February 11, 2025 15:04
Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging this, please use a conventional commit summary. For example:

fix(opentelemetry): preserve span labels in traces

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.80%. Comparing base (96124bc) to head (65cdd9d).
Report is 794 commits behind head on main.

Files with missing lines Patch % Lines
linkerd/opentelemetry/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3609      +/-   ##
==========================================
- Coverage   67.68%   66.80%   -0.88%     
==========================================
  Files         332      392      +60     
  Lines       15158    18414    +3256     
==========================================
+ Hits        10259    12301    +2042     
- Misses       4899     6113    +1214     
Files with missing lines Coverage Δ
linkerd/opentelemetry/src/lib.rs 0.00% <0.00%> (ø)

... and 171 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3cf6f3...65cdd9d. Read the comment docs.

@sfleen sfleen enabled auto-merge (squash) February 11, 2025 15:58
@sfleen sfleen merged commit 3229f4b into linkerd:main Feb 11, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants