Merged
Conversation
The HTTP type helpers use `Into` conversion for turning enum variants into integer values; but these conversions may be ambiguous in some cases, depending on what types are used in a project. This change replaces the use of `Into` with `as` to reliably convert these values. Signed-off-by: Oliver Gould <ver@buoyant.io>
hawkw
approved these changes
Jun 27, 2022
kleimkuhler
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP type helpers use
Intoconversion for turning enum variantsinto integer values; but these conversions may be ambiguous in some
cases, depending on what types are used in a project.
This change replaces the use of
Intowithasto reliably convertthese values.
Signed-off-by: Oliver Gould ver@buoyant.io