Add counter to collection and map views #4616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
changed the title
There was a problem hiding this comment.
The problem of this API change is that it is not tested. This is a problem but fortunately, here some tests can be done.
For example the count can be done on the bids / asks of the matching engine. So a simple addition to the end-to-end test suffices.
Another example is the number of accounts of the fungible, nfts of non-fungible, shares of amm among examples of MapView.
|
The code for |
afck
approved these changes
Sep 22, 2025
ma2bd
added a commit
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add some missing APIs + improve GraphQL code for collections
Proposal
Test Plan
CI + tested manually
Release Plan
These changes should be backported to the latest
testnetbranch, then be released in a new SDK.(Note that the SDK will be breaking certain queries but that's ok)