Skip to content

fix default storage namespace in backward compatible way #4569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix default storage namespace in backward compatible way #4569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions linera-service/src/cli/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
storage::{CommonStorageOptions, Runnable, RunnableWithStore, StorageConfig},
util, wallet,
};
use linera_storage::{DbStorage, Storage};
use linera_storage::{DbStorage, Storage, DEFAULT_NAMESPACE};
use linera_views::store::{KeyValueDatabase, KeyValueStore};
use serde_json::Value;
use tempfile::NamedTempFile;
Expand Down Expand Up @@ -1785,7 +1785,7 @@
path: Self::config_path()?.join("wallet.db"),
spawn_mode,
};
let namespace = "default".to_string();
let namespace = DEFAULT_NAMESPACE.to_string;

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / test 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / test 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / remote-net-test 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / benchmark-test 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / check-outdated-cli-md 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / storage-service-tests 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / ethereum-tests 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / default-features-and-witty-integration-test 

attempted to take value of method `to_string` on type `&'static str`

Check failure on line 1788 in linera-service/src/cli/main.rs

View workflow job for this annotation

GitHub Actions / lint-cargo-clippy 

attempted to take value of method `to_string` on type `&'static str`
Ok(StorageConfig {
inner_storage_config,
namespace,
Expand Down
2 changes: 1 addition & 1 deletion linera-storage/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ pub use crate::db_storage::TestClock;
pub use crate::db_storage::{ChainStatesFirstAssignment, DbStorage, WallClock};

/// The default namespace to be used when none is specified
pub const DEFAULT_NAMESPACE: &str = "table_linera";
pub const DEFAULT_NAMESPACE: &str = "default";

/// Communicate with a persistent storage using the "views" abstraction.
#[cfg_attr(not(web), async_trait)]
Expand Down
Loading