DRAFT: Make non-primary click events focus buttons and checkboxes. #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the web's behavior.
|
Curious what the reasoning is behind this and whether anyone else does this? |
|
The right click behaviour matches e.g. Firefox (but obviously, that also open a context menu, which we don't have). As accidentally demonstrated when I did right-click, escape, enter on the "ready for review" button! |
|
It's also the behavior for middle-click, and I assume other non-primary clicks? I haven't tested it in that much detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this as a draft, because I think we already want non-primary clicks on buttons to send actions. This very low-priority for now.