Skip to content

Conversation

melix99
Copy link
Contributor

@melix99 melix99 commented Jun 23, 2025

Implement HoveredBackground, ActiveBorderColor and DisabledBorderColor properties.

@melix99
Copy link
Contributor Author

melix99 commented Jun 23, 2025

Currently in draft because I can't figure out why it's not compiling. It's complaining about the CheckboxProps not implementing Default. I thought this was because of the missing macros for the increased number of properties, but after adding the macros, the error still happen. @PoignardAzur do you have any idea of why it's failing? Is there a limit of the number of properties in xilem views?

@Philipp-M
Copy link
Contributor

Philipp-M commented Jun 23, 2025

The issue is simply that Default is only implemented for tuples up to twelve elements.

So I guess we need a different strategy for storing (more) properties.

@PoignardAzur
Copy link
Contributor

Oh yeah, this is... inconvenient. I think the immediate takeaway is that our strategy for implementing properties in Xilem isn't going to scale.

I don't have any non-painful short-term solution, sorry.

@xb284524239
Copy link
Contributor

The border-style property also needs to be supported, with common values including dotted, dashed, solid, double, etc.

@PoignardAzur
Copy link
Contributor

I'm working on a fix for the "tuple too big" problem.

But also, I'd rather not provide the entire matrix of "modifier x property" combos. I've tried to add a small set of modified properties so users can start adding some visual interactivity to apps, but if we want to add the full spectrum, we'll need to implement a system for conditional properties. The existing properties like DisabledXxx, ActiveXxx, etc are a band-aid solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants