Skip to content

Get session #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 10, 2021
Merged

Get session #6

merged 5 commits into from
Aug 10, 2021

Conversation

hoangdat
Copy link
Member

@hoangdat hoangdat commented Jul 24, 2021 •
edited
Loading

  • parsing capabilities
  • parsing account
  • parsing primary account
  • test for session class
  • test for capabilities converter

@dab246 @chibenwa please review it

@hoangdat hoangdat mentioned this pull request Jul 24, 2021
Closed
dab246
dab246 reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should write unit test for it to check the correctness

@hoangdat hoangdat mentioned this pull request Jul 28, 2021
Closed
@hoangdat
Copy link
Member Author

@dab246 @chibenwa please check this PR. I make it generic for custom capability and unknown capability.

@hoangdat hoangdat marked this pull request as ready for review July 28, 2021 10:52
chibenwa
chibenwa reviewed Jul 28, 2021
View reviewed changes
chibenwa
chibenwa reviewed Jul 28, 2021
View reviewed changes
chibenwa
chibenwa approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what my opinion on Dart code is worth... LGTM

hoangdat
hoangdat commented Aug 2, 2021
View reviewed changes
@hoangdat hoangdat merged commit 452fcfc into linagora:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dab246 dab246 dab246 left review comments

@chibenwa chibenwa chibenwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoangdat @chibenwa @dab246