Skip to content

Introduce per-repo default reviewers #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jun 27, 2025

We allow the Github bot to assign a per-repo default reviewer for the first review.

cc @TheBlueMatt

As usual didn't have a chance to test this locally, let me know if I messed up somewhere.

tnull added 2 commits July 2, 2025 14:27
We allow the Github bot to assign a per-repo default reviewer for the first
review.
@tnull tnull force-pushed the 2025-06-default-reviewers branch from 6ef3159 to 0051a82 Compare July 2, 2025 12:27
@tnull
Copy link
Contributor Author

tnull commented Jul 2, 2025

Force-pushed with the following changes:

> git diff-tree -U2 6ef3159 0051a82
diff --git a/github_bot.py b/github_bot.py
index 38fb786..543886a 100644
--- a/github_bot.py
+++ b/github_bot.py
@@ -468,5 +468,5 @@ class GitHubBot:
                # reviewer for the given repo, assign them and return early.
                if not current_reviewers:
-                       default_reviewer = DEFAULT_FIRST_REVIEWER[repo_name]
+                       default_reviewer = DEFAULT_FIRST_REVIEWER.get(repo_name)
                        if default_reviewer is not None and default_reviewer != pr_author:
                                self.assign_reviewer(repo_name, pr_number, default_reviewer)

@tnull tnull requested a review from TheBlueMatt July 2, 2025 12:29
@TheBlueMatt TheBlueMatt merged commit cfa1ebd into lightningdevkit:main Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants