Skip to content

Replaced option_static_remotekey w/ CommitmentType. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Replaced option_static_remotekey w/ CommitmentType. #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf1107
Replaced option_static_remotekey w/ CommitmentType.
ksedgwic Sep 10, 2020
39b50d9
Improved NOTES
ksedgwic Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions contrib/remote_hsmd/NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ c-lightning

Setup

cd contrib/remote_hsmd && \
ln -s /path/to/rust-lightning-signer/src/server/remotesigner.proto
(cd contrib/remote_hsmd && \
ln -s ../../../rust-lightning-signer/src/server/remotesigner.proto)

Building

Expand All @@ -20,6 +20,10 @@ https://github.com/golemfactory/golem/issues/2168 for background.
pip3 install --user base58
pip3 install --user bitstring
pip3 install --user secp256k1
pip3 install --user mrkd

# in c-lightning root:
pip3 install --user -r requirements.txt

Run all of the integration tests:

Expand Down Expand Up @@ -83,14 +87,3 @@ rust-lightning-signer
----------------------------------------------------------------

cargo run --bin server |& tee log3

Signing Formats
```
rust-lightning c-lightning rust-lightning-signer
p2pkh P2PKH
p2sh
p2wpkh p2wpkh P2WPKH
p2shwpkh p2sh-p2wpkh P2SH_P2WPKH
p2wsh
p2shwsh
```
5 changes: 4 additions & 1 deletion contrib/remote_hsmd/proxy.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,10 @@ proxy_stat proxy_handle_ready_channel(
req.mutable_remote_basepoints());
req.set_remote_to_self_delay(remote_to_self_delay);
marshal_script(remote_shutdown_script, req.mutable_remote_shutdown_script());
req.set_option_static_remotekey(option_static_remotekey);
req.set_commitment_type(
option_static_remotekey ?
ReadyChannelRequest_CommitmentType_STATIC_REMOTEKEY :
ReadyChannelRequest_CommitmentType_LEGACY);

ClientContext context;
ReadyChannelReply rsp;
Expand Down