Component/preview #112
Open
Component/preview #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/styleguide/src/components/Preview/Preview.js
|
Ja som na toto trosku pozabudol, ale no stale mi to nejde nejak dole krkom. Technicky je to vsetko dobre. Filozoficky s tym mam trosku problem. Lighter-styleguide by mal byt, od komponentov ktorych dokumentaciu zobrazuje, nezavysli. Tym ze v nom urcim priamo nejake classy, ktore tie komponenty pouzivaju (co je ich vnotorna implementacia) tu zavyslost vytvaram. Este k tomu pridavam aj nejake zmeny (v tomto pripade css veci ako postition, padding atd.), ktore tu implementaciu menia? A teraz, ze co by mohlo byt riesenim.
A teda moze byt toto mergnute, ked @jurajk povies, len tieto vyhrady, ak su relevantne si zapisme do taskov. |
|
@adammockor inak sak mame na to task, aha https://app.asana.com/0/459452259993903/758224398048331/f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otvaram toto nanovo, lebo do dusanovho PR #110 neviem poslat commity :/