Update Ghidra HEAD to commit 5ab72bf4f + UBSAN issue #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed files: ``` M Ghidra/Features/Decompiler/src/decompile/cpp/Makefile M Ghidra/Features/Decompiler/src/decompile/cpp/architecture.cc A Ghidra/Features/Decompiler/src/decompile/cpp/constseq.cc A Ghidra/Features/Decompiler/src/decompile/cpp/constseq.hh M Ghidra/Features/Decompiler/src/decompile/cpp/coreaction.cc M Ghidra/Features/Decompiler/src/decompile/cpp/coreaction.hh M Ghidra/Features/Decompiler/src/decompile/cpp/database.cc M Ghidra/Features/Decompiler/src/decompile/cpp/database.hh M Ghidra/Features/Decompiler/src/decompile/cpp/flow.cc M Ghidra/Features/Decompiler/src/decompile/cpp/funcdata.cc M Ghidra/Features/Decompiler/src/decompile/cpp/funcdata.hh M Ghidra/Features/Decompiler/src/decompile/cpp/funcdata_block.cc M Ghidra/Features/Decompiler/src/decompile/cpp/funcdata_varnode.cc M Ghidra/Features/Decompiler/src/decompile/cpp/jumptable.cc M Ghidra/Features/Decompiler/src/decompile/cpp/merge.cc M Ghidra/Features/Decompiler/src/decompile/cpp/op.cc M Ghidra/Features/Decompiler/src/decompile/cpp/op.hh M Ghidra/Features/Decompiler/src/decompile/cpp/printc.cc M Ghidra/Features/Decompiler/src/decompile/cpp/ruleaction.cc M Ghidra/Features/Decompiler/src/decompile/cpp/sleighbase.cc M Ghidra/Features/Decompiler/src/decompile/cpp/stringmanage.cc M Ghidra/Features/Decompiler/src/decompile/cpp/stringmanage.hh M Ghidra/Features/Decompiler/src/decompile/cpp/subflow.cc M Ghidra/Features/Decompiler/src/decompile/cpp/type.cc M Ghidra/Features/Decompiler/src/decompile/cpp/type.hh M Ghidra/Features/Decompiler/src/decompile/cpp/typeop.cc M Ghidra/Features/Decompiler/src/decompile/cpp/userop.cc M Ghidra/Features/Decompiler/src/decompile/cpp/userop.hh M Ghidra/Features/Decompiler/src/decompile/cpp/variable.cc M Ghidra/Features/Decompiler/src/decompile/cpp/variable.hh M Ghidra/Features/Decompiler/src/decompile/cpp/varmap.cc M Ghidra/Features/Decompiler/src/decompile/cpp/varmap.hh A Ghidra/Features/Decompiler/src/decompile/datatests/stackstring.xml ```
Contributor
|
Update: After doing some testing, the failure in the tests is caused by a change somewhere in the UBSAN fixes patch file https://github.com/lifting-bits/sleigh/blob/2d6564857152983a6759162a7cb2e15e21b12f64/src/patches/HEAD/0001-Fix-UBSAN-errors-in-decompiler.patch |
Tests now pass. It is unclear whether the tests rely on this undefined behavior or not. It is also unclear whether the tests even trigger undefined behavior at this location anymore. This will be revisited when future testing with sanitizers is investigated and integrated into CI. Regenerate the patch set.
ekilmer
force-pushed
the
cron/update-ghidra-5ab72bf4f
branch
from
683e28c to
d20de25
Compare
ekilmer
changed the title
ekilmer
changed the title
Contributor
|
Hmmmm. Windows Debug builds of HEAD seem to time out. Need to test this further. |
ekilmer
force-pushed
the
cron/update-ghidra-5ab72bf4f
branch
from
6eb0cd1 to
d20de25
Compare
Contributor
|
Superseded and included in #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove UBSAN fix in funcdata_varnode.cc
Tests now pass. The UBSAN changes will be revisited when future testing with sanitizers is investigated and integrated into CI.
Update Ghidra HEAD to commit 5ab72bf4f. Changed files: