Skip to content

Resolved issues with MOVSX and MOVSXD. #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kyle-elliott-tob merged 1 commit into from
Dec 11, 2025
Merged

Resolved issues with MOVSX and MOVSXD. #740

kyle-elliott-tob merged 1 commit into from
Dec 11, 2025

Conversation

@fvrmatteo
Copy link
Contributor

@fvrmatteo fvrmatteo commented Dec 10, 2025

With the bump to the new XED version there are a bunch of instructions that have additional encoding templates (iform in XED parlance) that need to be added to the semantics.

The easiest way to spot them is to diff the iclass and iform columns of the idata.txt file between the old and new XED versions.

This is an example fixed by the current PR:

Old XED:

MOVSX               BASE            DATAXFER        MOVSX_GPRv_GPR16               I386                 SCALABLE
MOVSX               BASE            DATAXFER        MOVSX_GPRv_GPR8                I386                 SCALABLE
MOVSX               BASE            DATAXFER        MOVSX_GPRv_MEMb                I386                 SCALABLE
MOVSX               BASE            DATAXFER        MOVSX_GPRv_MEMw                I386                 SCALABLE

MOVSXD              LONGMODE        DATAXFER        MOVSXD_GPRv_GPRz               LONGMODE             SCALABLE
MOVSXD              LONGMODE        DATAXFER        MOVSXD_GPRv_MEMz               LONGMODE             SCALABLE

New XED:

MOVSX               BASE            DATAXFER        MOVSX_GPR16_MEMw               I386                 INVALID
MOVSX               BASE            DATAXFER        MOVSX_GPR32_MEMw               I386                 INVALID
MOVSX               BASE            DATAXFER        MOVSX_GPR64_MEMw               I386                 INVALID
MOVSX               BASE            DATAXFER        MOVSX_GPRv_GPR16               I386                 SCALABLE
MOVSX               BASE            DATAXFER        MOVSX_GPRv_GPR8                I386                 SCALABLE
MOVSX               BASE            DATAXFER        MOVSX_GPRv_MEMb                I386                 SCALABLE
MOVSX               BASE            DATAXFER        MOVSX_GPRv_MEMw                I386                 SCALABLE

MOVSXD              LONGMODE        DATAXFER        MOVSXD_GPR64_MEMd              LONGMODE             INVALID
MOVSXD              LONGMODE        DATAXFER        MOVSXD_GPRv_GPRz               LONGMODE             SCALABLE
MOVSXD              LONGMODE        DATAXFER        MOVSXD_GPRz_MEMz               LONGMODE             SCALABLE

@kyle-elliott-tob kyle-elliott-tob mentioned this pull request Dec 11, 2025
Open
4 tasks
@kyle-elliott-tob kyle-elliott-tob merged commit 36c1d3c into lifting-bits:master Dec 11, 2025
8 of 17 checks passed
@btridev btridev mentioned this pull request Dec 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyle-elliott-tob kyle-elliott-tob kyle-elliott-tob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fvrmatteo @kyle-elliott-tob