Skip to content

win: lazy-load [GS]etThreadDescription symbols #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

bnoordhuis
Copy link
Member

As said symbols are unavailable on Windows Server 2016.

Fixes: #4677

As said symbols are unavailable on Windows Server 2016.

Fixes: libuv#4677
@bnoordhuis
Copy link
Member Author

Not sure why that breaks Windows Server 2019 and 2022... anyone have ideas? The thread name test now fails with UV_ENOSYS so apparently libuv is not finding the symbols.

@santigimeno
Copy link
Member

The actual test doesn't need to use a uv_loop_t instance so uv_loop_init() is never called, so uv__winapi_init() isn't either. Maybe move the new code to a separate function which is called uv_once() from the new thread name methods?

@bnoordhuis
Copy link
Member Author

The actual test doesn't need to use a uv_loop_t instance so uv_loop_init() is never called, so uv__winapi_init() isn't either. Maybe move the new code to a separate function which is called uv_once() from the new thread name methods?

Oh, that's such a footgun... but yeah, I missed that. Thanks!

@bnoordhuis bnoordhuis merged commit 8235116 into libuv:v1.x Jan 24, 2025
18 checks passed
@bnoordhuis bnoordhuis deleted the fix4677 branch January 24, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Windows Server 2016
5 participants