Skip to content

drop support of macOS 10.5 and earlier #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

Youw
Copy link
Member

@Youw Youw commented Nov 17, 2019

IOHIDDeviceGetService is available since macOS 10.6
dropping an old workaround makes the implementation simpler

Similar to #39.

Fixes #119
Closes #120

IOHIDDeviceGetService is available since macOS 10.6
dropping an old workaround makes the implementation simpler
@Youw Youw force-pushed the macos-drop-macos-workaround branch from 816bc03 to 4e33e3e Compare November 17, 2019 21:19
@Youw Youw requested a review from a team November 18, 2019 23:28
@Youw Youw added the macOS Related to macOS backend label Nov 18, 2019
@Youw
Copy link
Member Author

Youw commented Nov 29, 2019

Any votes against?

@z3ntu
Copy link
Collaborator

z3ntu commented Nov 29, 2019

I'm fine personally with 10.6.8+ being supported. But there are definitely still people with macOS versions lower than 10.6 that are interested in software on those devices (see e.g. https://github.com/mistydemeo/tigerbrew - this is not just PPC but now everything < 10.9 or something because homebrew dropped support for macOS versions lower than that)

@Youw
Copy link
Member Author

Youw commented Nov 29, 2019

In this particular example, tigerbrew Formula is still using signal11's copy of the repo: (current master) https://github.com/mistydemeo/tigerbrew/blob/4cce1912cc68a15a0d47f5744b489ae68dfe94fa/Library/Formula/hidapi.rb

@Youw
Copy link
Member Author

Youw commented Nov 29, 2019

Maybe it is time, to finally fire a new release, and it will be a last release, that supports macOS 10.5.

@todbot
Copy link
Contributor

todbot commented Nov 29, 2019

I'm fine with this PR. MacOS USB & HID pre-10.6 always had weirdnesses and new macos adoption rate is typically very high among its users.

If we're talking new releases (yay), I like to lobby for #125 being included.

@mcuee
Copy link
Member

mcuee commented Jan 27, 2021

Good to update and merge this one if it has not been merged.

@mcuee
Copy link
Member

mcuee commented Jun 14, 2021

@Youw Please merge this as well. Thanks.

@Youw Youw merged commit 42fa21f into master Jun 14, 2021
@Youw Youw deleted the macos-drop-macos-workaround branch June 14, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Related to macOS backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: location of IOKit.framework
6 participants