Skip to content

wayland: Ensure that the toplevel window is recreated when switching … #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kontrabant
Copy link
Contributor

…decoration modes

If a compositor tries to change the decoration mode when initially creating a window, the hidden flag might not yet be unset if the decoration mode is changed during the initial roundtrip in Wayland_ShowWindow(). As hiding the window destroys the decoration manager object, the hidden flag check is unnecessary, as the decoration configuration listener will never be entered when the window is hidden.

Fixes #8173

…decoration modes

If a compositor tries to change the decoration mode when initially creating a window, the hidden flag might not yet be unset if the decoration mode is changed during the initial roundtrip in Wayland_ShowWindow(). As hiding the window destroys the decoration manager object, the hidden flag check is unnecessary, as the decoration configuration listener will never be entered when the window is hidden.
@Kontrabant Kontrabant merged commit 37e1fc3 into libsdl-org:main Sep 6, 2023
@Kontrabant
Copy link
Contributor Author

Cherry-picked the bugfix to SDL2 as well.

@Kontrabant Kontrabant deleted the wayland_decoration_switch_fix branch December 8, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible CSD vs SSD when using SDL_VIDEODRIVER=wayland
1 participant