[SDL2] test: Don't expect a specific error message #14680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
SDL_GetError() never returns NULL. The check should be |
SDL3 + sdl2-compat doesn't give precisely the same error message as "classic" SDL2 here. To facilitate the transition from "classic" SDL2 to sdl2-compat, allow either one. This allows the "classic" SDL2 test suite to be run against sdl2-compat, demonstrating that sdl2-compat is indeed compatible with the version that it's replacing. Signed-off-by: Simon McVittie <[email protected]>
smcv
force-pushed
the
sdl2-relax-message-assert
branch
from
c5a4696 to
93adca5
Compare
Collaborator
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL3 + sdl2-compat doesn't give precisely the same error message as "classic" SDL2 here. To facilitate the transition from "classic" SDL2 to sdl2-compat, allow either one. This allows the "classic" SDL2 test suite to be run against sdl2-compat, demonstrating that sdl2-compat is indeed compatible with the version that it's replacing.
I'm looking into what needs to happen for Debian (and indirectly Ubuntu) to replace "classic" SDL2 with sdl2-compat, following in the footsteps of other distros like Arch and Fedora. Specifically, the version of
sdl2-compatinexperimentaltakes over the package nameslibsdl2-2.0-0andlibsdl2-devpreviously provided by "classic" SDL2, so that it will become the default.In Debian's automated test machinery, the "as-installed" tests for all existing packages that depend on a particular library are run against new proposed versions of that library. In the case where the package name
libsdl2-2.0-0is taken over, the result is that we run both the "classic" SDL2 test suitelibsdl2-testsand the sdl2-compat test suitelibsdl2-compat-testsagainst the sdl2-compat library (currently only with thedummyaudio and video backends). This might seem unexpected, but it does seem like a a good way to prove that sdl2-compat is actually compatible with "classic" SDL2 during the transition, and these error messages seem to be the only assertions that actually need relaxing.