Skip to content

Protocols not waking up the task #1516

@koivunej

Description

@koivunej

It is possible that floodsub (0.16, latest master) will create NetworkBehaviourActions in self.events but never wake the task calling NetworkBehaviour::poll through std::task::Waker. Looking at libp2p protocols as a whole there are uses of VecDeque use but no waker use in kad, identify, gossipsub and floodsub.

Am I missing something on how the libp2p is supposed to wake up tasks, or is the caller library user expected to wakeup the task manually on some timer or something else? I've understood that the expected behaviour with methods returning std::task::Poll<T> which take the std::task::Context argument is to notify through the context's waker having made progress.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions