network: rename NAT Types #3331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/rename-nat-type
branch
3 times, most recently
from
52427b8 to
fa8b1ce
Compare
MarcoPolo
reviewed
Jul 25, 2025
MarcoPolo
approved these changes
Jul 25, 2025
Collaborator
MarcoPolo
left a comment
MarcoPolo
left a comment
There was a problem hiding this comment.
would be nice if the comment fit within 80 chars
EndpointIndependent vs EndpointDependent is much more suggestive than Cone vs Symmetric Picked this from: https://educatedguesswork.org/posts/nat-part-2/#how-to-get-through-a-nat
sukunrt
force-pushed
the
sukun/rename-nat-type
branch
from
fa8b1ce to
2c8e473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EndpointIndependent vs EndpointDependent is much more suggestive than Cone vs Symmetric
Picked this from: https://educatedguesswork.org/posts/nat-part-2/#how-to-get-through-a-nat