ci: add golangci-lint for linting #3269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
push-szzpvwlsuuny
branch
4 times, most recently
from
5165014 to
a9a5125
Compare
sukunrt
force-pushed
the
push-szzpvwlsuuny
branch
from
a9a5125 to
be83c9c
Compare
There was a problem hiding this comment.
@galargh any reason golangci-lint isn't part of unified ci?
Other repos could also benefit from it
|
There's this discussion where not everyone's convinced they need this. ipld/ipld#92 |
MarcoPolo
approved these changes
Apr 9, 2025
The current plan is to add it as an optional additional step that could be easily enabled via Unified CI's config. Once it's out, I'll make sure to update the configuration here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures ci to use golang-ci for linting.
The workflow is copied from quic-go. The os specific checks don't add too much value, I guess. I am fine with keeping only linux.
I couldn't get the unparam linter to detect unused parameters in functions. I guess it is aggressive about not raising failse positives. Using revive for unparam check.
I fear errcheck may be too much some times. We can disable / configure that one when we come across a change that warrants it.
See: https://github.com/libp2p/go-libp2p/actions/runs/14307422981/job/40094362132?pr=3269
for a failure.
See: #1843 for past discussion on this.
Fixes: #3248